Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub App authentication support to the deployment tracker, allowing authentication via GitHub App credentials instead of only Personal Access Tokens (PATs). When both authentication methods are configured, the GitHub App takes precedence.
Changes:
- Added GitHub App authentication using the
ghinstallationpackage for automatic token management - Introduced three new environment variables for GitHub App configuration (app ID, installation ID, and private key path)
- Updated documentation to describe both PAT and GitHub App authentication methods
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/deploymentrecord/client.go | Added WithGHApp option and transport field; updated PostOne to prioritize GitHub App authentication |
| internal/controller/controller.go | Added logic to configure GitHub App client options when credentials are present |
| internal/controller/config.go | Added three new config fields for GitHub App credentials |
| go.mod | Added dependencies for GitHub App authentication (ghinstallation, golang-jwt, go-github) |
| cmd/deployment-tracker/main.go | Added environment variable loading for GitHub App credentials |
| README.md | Updated documentation with authentication section and GitHub App environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for authenticating with a GitHub App instead of a PAT. If both are provided, the GitHub App takes precedence.
The used package for token management automatically takes care of token renewal, and is thread safe.